grpc-js: Always use RetryingCall, always call onCommitted #2884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is to modify the implementation of the
grpc.enable_retries
option. Now, when it is set to 0, instead of skippingRetryingCall
entirely and makingLoadBalancingCall
a direct child ofResolvingCall
,RetryingCall
is used in a new mode that does not perform any retries.The main purpose of this is to create a place to correctly call
CallConfig#onCommitted
consistently, whether or not that option is set. Previously, it would only be called inLoadBalancingCall
after starting theSubchannelCall
. This was both too early (if the call was later retried) and it could fail to be called (if the LB pick failed).One other change this required was performing the functionality of
commitCall
even if the underlying call already completed, which means that buffered messages will now be cleared more consistently, and theMessageBufferTracker
should track messages cleared this way more consistently.