Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Propagate error messages through LB policy tree #2868

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

murgatroid99
Copy link
Member

This modifies the ChannelControlHelper#updateState function signature to add an errorMessage argument, which can be either a string or null. The expectation is that it should be a string when the status is TRANSIENT_FAILURE, and null otherwise. The purpose of this is to enable LB policies with multiple children to provide some error information from clients when synthesizing an aggregate status to be passed to their parents. In order to avoid including excessive information in the status message, each such LB policy only passes along the last error message it has seen from any child.

@murgatroid99 murgatroid99 merged commit 5cd30ae into grpc:master Dec 10, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant