logging: store the propagated context in the reporter #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Cano <[email protected]>
kindermoumoute
force-pushed
the
fixaddfields
branch
from
94a6c8a to
3517e4f
Compare
johanbrandhorst
approved these changes
Dec 28, 2024
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#739 doesn't work without this change because the fields were not extracted from the same context than the one being propagated. I should've tested this better in my previous MR 🙌
Changes
testpb.TestPingService.PingmethodVerification
AddFieldswith thePingmethod using thePingFunchelperTestPingto assert a new field