Initial integration with fortio.org/terminal #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Aug 9, 2024
ccoVeille
reviewed
Aug 9, 2024
main.go
Outdated
| @@ -28,24 +29,34 @@ func Main() int { | |||
| compact := flag.Bool("compact", false, "When printing code, use no indentation and most compact form") | |||
| showEval := flag.Bool("eval", true, "show eval results") | |||
| sharedState := flag.Bool("shared-state", false, "All files share same interpreter state (default is new state for each)") | |||
| configDir, err := os.UserConfigDir() // TODO: this is ugly on a mac... allow homedir... | |||
| historyFileDefault := filepath.Join(configDir, ".grol_history") | |||
There was a problem hiding this comment.
Suggested change
| historyFileDefault := filepath.Join(configDir, ".grol_history") | |
| historyFileDefault := filepath.Join(configDir, "grol", "history") |
There was a problem hiding this comment.
and now I have to mkdir all etc...? isn't it enough to use the config dir and put files there
There was a problem hiding this comment.
It's dirty. I would prefer if you added a .grol_history file at the root of home folder than creating a file at the root of config folder.
There was a problem hiding this comment.
ok so I switched back to homedir as default but added GROL_HISTORY_FILE env var for people who don't like it so they don't have to set it in the flag either, does that work?
ccoVeille
approved these changes
Aug 10, 2024
…e home dir as a virtual '~/' that gets replaced by actual if unchanged from default, so pasting help doesn't leak the home dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets arrow keys and history - integration of several days of work to create https://github.com/fortio/terminal and improve the original golang.org/x/term through golang/term#15 (and in a usable fork while waiting: https://github.com/fortio/term)
Only adds 51k 🎉
Fixes #110