Drop glyphicons and replace it by already existing icons in icons.css

[hexaltation]

Context

Bump bootstrap from 3.4.1 to 5.3.3 lead to a bug.
In v 4.0.0 bootstrap dropped glyphicon usage.
Grist-core code have some occurences of glyphicon.

$ grep -rin glyphicon
client/lib/koForm.js:337:    this.optionButton("left", dom('span.glyphicon.glyphicon-align-left'),
client/lib/koForm.js:339:    this.optionButton("center", dom('span.glyphicon.glyphicon-align-center'),
client/lib/koForm.js:341:    this.optionButton("right", dom('span.glyphicon.glyphicon-align-right'),
client/lib/koForm.js:482:            dom('span.kf_drag_indicator.glyphicon.glyphicon-option-vertical') :
client/lib/koForm.js:487:            return dom('span.drag_delete.glyphicon.glyphicon-remove',
client/components/DocConfigTab.js:19:      dom('span.glyphicon.glyphicon-check'),
client/components/ValidationPanel.js:66:            dom('div.validation_trash.glyphicon.glyphicon-remove',
client/components/ValidationPanel.js:71:            1, dom('div.glyphicon.glyphicon-tag.config_icon'),
client/components/ColumnFilters.css:69:.g-glyphicon-tristate {
client/components/RecordLayoutEditor.js:128:    dom('div.g_record_delete_field.glyphicon.glyphicon-eye-close',
client/widgets/AttachmentsWidget.ts:193:const cssAttachmentIcon = styled('div.glyphicon.glyphicon-paperclip', `

Proposed solution

Remove Glyphicon calls and replace it by corresponding icons in static/icon/icons.css

Related issues

Fixes #1412

Has this been tested?

• 👍 yes, I added tests to the test suite
• 💭 no, because this PR is a draft and still needs work
• 🙅 no, because this is not relevant here
• 🙋 no, because I need help

[paulfitz]

Related report: https://community.getgrist.com/t/bug-in-my-self-hosted-instance-no-paperclip-icon-on-attachment-field/8222/2

[georgegevoian]

For the most recent browser test failure, you can just remove the failing test (related to the now-removed validation feature). If you grep the codebase for validationsTool, there's a few other small things you can remove as well.

[github-actions]

Deployed commit 44a2f31d031b9c3d36ca938e6545005b398c0b01 as https://grist-hexaltation-grist-core-drop-glyphicons-for-octicons.fly.dev (until 2025-03-08T15:28:27.605Z)

[paulfitz]

Haven't looked at code, but not seeing paperclip in the preview?

[github-actions]

Deployed commit 12ba314cde18b8716f1babf165179907865a993d as https://grist-hexaltation-grist-core-drop-glyphicons-for-octicons.fly.dev (until 2025-03-08T16:09:55.056Z)

[github-actions]

Deployed commit 5d046283e3a23731cfcc37f10e11141d867c44ab as https://grist-hexaltation-grist-core-drop-glyphicons-for-octicons.fly.dev (until 2025-03-08T16:20:18.406Z)

[hexaltation]

For the most recent browser test failure, you can just remove the failing test (related to the now-removed validation feature). If you grep the codebase for validationsTool, there's a few other small things you can remove as well.

Thanks
it's now cleaned

[github-actions]

Deployed commit 61fb981659c229c8fa5054c69d4c12a57afa1243 as https://grist-hexaltation-grist-core-drop-glyphicons-for-octicons.fly.dev (until 2025-03-08T16:33:21.584Z)

[github-actions]

Deployed commit dd05dcd1fd5dd1785e3ffee4a87ff84ac513800c as https://grist-hexaltation-grist-core-drop-glyphicons-for-octicons.fly.dev (until 2025-03-08T16:54:36.538Z)

[georgegevoian]

Thanks @hexaltation.