Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing queried tableId in error when table not found #1410

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

fflorent
Copy link
Collaborator

Context

We had an error in production with a corrupted document which could not find a certain table. But there missed the queried table id or table ref in the error

Proposed solution

Show what query was unsuccessful.

Related issues

N/A

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

@fflorent fflorent requested a review from paulfitz January 31, 2025 14:09
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fflorent ! Just one question.

app/server/lib/GranularAccess.ts Show resolved Hide resolved
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fflorent !

@paulfitz paulfitz merged commit 983e27b into gristlabs:main Feb 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants