Adds 'snapshot' mode to external attachments #1409
Draft
+90
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfitz
reviewed
Jan 30, 2025
| @@ -5,6 +5,7 @@ import {ICreateAttachmentStoreOptions} from './ICreate'; | |||
| import * as fse from 'fs-extra'; | |||
| import path from 'path'; | |||
| import * as tmp from 'tmp-promise'; | |||
| import {create} from 'app/server/lib/create'; | |||
| case "test": | ||
| case 'snapshots': | ||
| return 'snapshots'; | ||
| case 'test': | ||
| return 'test-filesystem'; |
There was a problem hiding this comment.
Is there value in mapping test|snapshots to test-filesystem|snapshots? How is this making the world better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
External attachments only support a
testmode, since theGRIST_EXTERNAL_ATTACHMENTS_MODEconfig was added. This prevents Grist being used with MinIO for testing.Proposed solution
This adds the 'snapshot' option to
GRIST_EXTERNAL_ATTACHMENTS_MODE, which makes Grist use the same storage for external attachments that document snapshots use.Related issues
#1358
Has this been tested?