Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add curl to Grist image #1405

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Add curl to Grist image #1405

merged 1 commit into from
Jan 28, 2025

Conversation

georgegevoian
Copy link
Contributor

Context

For Docker healthchecks, curl or an equivalent tool needs to be added to the Grist image.

Proposed solution

Add curl to the Grist image.

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

@georgegevoian georgegevoian mentioned this pull request Jan 28, 2025
Merged
paulfitz
paulfitz approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @georgegevoian ! People have asked for this in the past.

@georgegevoian georgegevoian merged commit 4e96221 into main Jan 28, 2025
12 checks passed
@georgegevoian georgegevoian deleted the curl branch January 28, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfitz paulfitz paulfitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgegevoian @paulfitz