OIDConfig.getLogoutRedirectUrl: use redirectURL when possible #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
approved these changes
Jan 16, 2025
When GRIST_OIDC_IDP_SKIP_END_SESSION_ENDPOINT is true, we can actually use the requested destination URL since there is no constraint imposed by the OIDC provider. Co-authored-by: fflorent <[email protected]>
jonathanperret
force-pushed
the
oidc-use-redirecturl-if-possible
branch
from
5350e6f to
7ef389b
Compare
georgegevoian
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In #1276 we fixed the issue that OIDC logouts failed because of Grist using a variable post-logout URI.
Looking at the code again, we realized that when the user had disabled OIDC logouts by setting
GRIST_OIDC_IDP_SKIP_END_SESSION_ENDPOINTtotrue, Grist could actually use the requested post-logout URI.Proposed solution
When
GRIST_OIDC_IDP_SKIP_END_SESSION_ENDPOINTis set totrue, use the provided URL as the post-logout URI.Has this been tested?