Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations #1379

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix translations #1379

merged 2 commits into from
Jan 14, 2025

Conversation

audez
Copy link
Contributor

@audez audez commented Jan 14, 2025

Context

Some strings are not translated in the UI. It comes from the fact that:

  • some strings are not wrapped in the translation function
  • in some files, the strings are wrapped in the translation function - and most of the time they have been translated in Weblate - but the translation function has the wrong scope, leading to a non-translated string on the UI

Proposed solution

Here I fixed some "simple" cases that I can handle, specifically in the "form" module. For more complex cases, I let @fflorent and other good developers take the lead :)
I will do more PRs for other strings.

The solution is:

  • Wrapping the strings in the translation function
    and/or
  • adding the right scope to the translation function

Related issues

#627
#962

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

Screenshots / Screencasts

An example of untranslated strings on the French UI:

Screenshot 2025-01-14 at 18 33 16

Copy link
Collaborator

@fflorent fflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @audez! 🙏

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audez, @fflorent

@paulfitz paulfitz merged commit e5bba90 into gristlabs:main Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants