make small tweaks in preparation for freshening grist-static #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes some small changes for the benefit of an update to grist-static, which has become quite stale. * When testing grist-static with latest grist-core, a problem showed up where `_encodeValue` is now sometimes called with `undefined` which is a problem for SQLite wrappers other than node-sqlite3. This change encodes it as null, which appears to be the intent. * Small non-obvious tweaks related to webpack and specific packages that do no harm in grist-core and remove a problem in grist-static.
jordigh
approved these changes
Jan 7, 2025
|
Thanks for reviewing @jordigh! The corresponding changes to use this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some small changes for the benefit of an update to grist-static, which has become quite stale.
_encodeValueis now sometimes called withundefinedwhich is a problem for SQLite wrappers other than node-sqlite3. This change encodes it as null, which appears to be the intent.You can preview where this will go at https://gristlabs.github.io/grist-static/next.html by clicking on the "investment research" image to get a popup. It will be somewhat slow because the document shown hasn't been upgraded to latest Grist so full data engine in pyodide/python needs to start and run migrations before rendering can begin.