env variables for ACTION_HISTORY limits #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vviers
reviewed
Oct 15, 2024
fflorent
force-pushed
the
issue1121
branch
2 times, most recently
from
b079a17 to
65478d9
Compare
AppSettings seems more future-proof and already raises error when passed value is not a number. We also introduce minValue and maxValue so we can constraint the configured value to be within a certain range and avoid erratic behavior when the value has not been expected.
Co-authored-by: Vincent Viers <[email protected]>
hexaltation
suggested changes
Oct 16, 2024
There was a problem hiding this comment.
Please correct the value of 100GB to 1GB as suggested by @vviers
for GRIST_ACTION_HISTORY_MAX_BYTES
Thank you for the tests :)
paulfitz
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Partial fix of #1121
As a self-hoster, I want to be able to parameterize ACTION_HISTORY max sizes (both as rows and as disk space)
Proposed solution
Introduce 2 env variables to make those limits configurable.
I made these two values require to be strictly positive.
Also I introduced check for minimum values (
minValue) and for the maximum values (maxValue) forAppSettings.readInt()/AppSettings.requireInt()and took the opportunity to force the timeout for OIDC to be positive.Also as I introduced some changes in AppSettings, I started testing this module. I felt like it would take some time to test everything, so I start small with this test and only test properly the methods related to integers (
readIntandrequireInt).Related issues
Fixes #1121
Has this been tested?