Pin browser tests to Chrome 127 #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berhalak
reviewed
Sep 2, 2024
jordigh
approved these changes
Sep 3, 2024
| export TEST_CLEAN_DATABASE="true" | ||
| export TEST_SUPPORT_API_KEY="api_key_for_support" | ||
|
|
||
| exec "$@" |
There was a problem hiding this comment.
I like the cleanup to have this all in one place, and I'm happy too about pinning the Chrome version.
As a follow-up, we should have some automation to increase the version number with new releases and automatically merge in a new version number if the CI passes.
hexaltation
pushed a commit
to hexaltation/grist-core
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A handful of browser tests began failing in Chrome 128+ (#1185), which the CI workflow began using recently.
The root cause appears to be a change in alert behavior when running automated tests: alerts are no longer shown, even when the BiDi Selenium driver is used.
Proposed solution
Pin Chrome to version 127 when running any browser tests. Follow up later with a fix or workaround.
Has this been tested?