Activations: add an enabled_at column #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordigh
force-pushed
the
jordigh/add-enabled-column
branch
5 times, most recently
from
fd45e56 to
17558f0
Compare
paulfitz
approved these changes
Aug 2, 2024
berhalak
requested changes
Aug 5, 2024
jordigh
force-pushed
the
jordigh/add-enabled-column
branch
from
17558f0 to
953b4a6
Compare
For #1140, I considered trying to use the existing fields in a better way, but because we already use the activations table to store preferences, we need to keep all of the existing data and its usage as-is. The enterprise code will use this new column to decide how long the trial period should be.
jordigh
force-pushed
the
jordigh/add-enabled-column
branch
from
953b4a6 to
e20cddd
Compare
|
Since this has migration in it, can you wait with merging after having at least 1-green pass (hopefully after #1152 gets merged)? |
jordigh
force-pushed
the
jordigh/add-enabled-column
branch
from
e20cddd to
4dfbda6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1140, I considered trying to use the existing fields in a better way, but because we already use the activations table to store preferences, we need to keep all of the existing data and its usage as-is.
The enterprise code will use this new column to decide how long the trial period should be.