create: make the default session secret default in all contexts

[jordigh]

The problem here is that making it this optional meant that it wasn't supplied by the enterprise creation
function. This resulted in an odd situation where the secret was required for the enterprise edition, even though it offers no additional security. Without this key, the enterprise code crashes.

The requirement to supply a secret key would make a Grist instance crash if you start in normal mode but switch to enterprise, as the enterprise creator does not supply a default secret key.

[berhalak]

Can you change the title? Or explain what it means?
Also, can you write a summary in the first comment, what is actually change here.

[jordigh]

Is that title better?

[berhalak]

Is that title better?

Yes, thank you. And what does create: stands for?

[jordigh]

Is that title better?

Yes, thank you. And what does create: stands for?

The general topic of the commit. This commit is about the create family of functions.

Each commit should describe what it's about so that reading git history is meaningful without reference to github or Phabricator. The commit messages should be useful on their own.

[berhalak]

Is that title better?

Yes, thank you. And what does create: stands for?

The general topic of the commit. This commit is about the create family of functions.

Each commit should describe what it's about so that reading git history is meaningful without reference to github or Phabricator. The commit messages should be useful on their own.

Is this some general guideline? Can you share a link to it?

[paulfitz]

That looks right to me. Sorry the SaaS tied your hands for cleaning up more. Although the hard-coded secret has always been there and you are just moving it, could you add a comment to it summarizing our understanding of its significance?

[berhalak]

Thanks.