Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: explicitly add a dummy ext/ directory #1102

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Jul 11, 2024

Having it checked in to git caused problems with Grist Desktop and Grist Static because their build processes expected to have nothing there, as well as interfering with checking out Grist Core as a submodule.

So we do this instead.

Having it checked in to git caused problems with Grist Desktop and
Grist Static because their build processes expected to have nothing
there, as well as interfering with checking out Grist Core as a
submodule.

So we do this instead.
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible we are finally done with the ext dance?? :)

@jordigh
Copy link
Contributor Author

jordigh commented Jul 11, 2024

Is it possible we are finally done with the ext dance?? :)

Dear goodness, I hope so.

@jordigh jordigh merged commit a437dfa into main Jul 11, 2024
13 of 18 checks passed
@jordigh jordigh deleted the jordigh/remove-ext branch July 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants