Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configures Enterprise Edition image to automatically start with enterprise features enabled #1084

Merged
merged 13 commits into from
Jul 8, 2024

Conversation

Spoffy
Copy link
Contributor

@Spoffy Spoffy commented Jul 2, 2024

Updates the Github workflow for docker_latest to separate out the Grist EE image build, as it requires special settings.

Additionally, parameterises a number of settings to make forking and debugging easier.

@berhalak
Copy link
Contributor

berhalak commented Jul 3, 2024

Is the title of this PR accurate and aligned with the description?

@paulfitz
Copy link
Member

paulfitz commented Jul 3, 2024

Is the title of this PR accurate and aligned with the description?

Yes, it is to fix something in the grist-ee image that broke recently. Perhaps the word "enabled" is ambiguous. It means that the grist-ee image when started will act as grist-ee has always acted (until it broke recently), and use material in grist-ee/ext. When it broke, it stopped doing that until an activation key was provided in the environment, so trialing stopped working. The most important line in the change is file: ext/Dockerfile which is used to set an environment variable in the image.

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Spoffy

@paulfitz paulfitz merged commit 90a9291 into gristlabs:main Jul 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants