Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable external contributors to create previews #1068

Merged
merged 26 commits into from
Jul 3, 2024
Merged

Enable external contributors to create previews #1068

merged 26 commits into from
Jul 3, 2024

Conversation

SleepyLeslie
Copy link
Collaborator

@SleepyLeslie SleepyLeslie commented Jun 26, 2024 •
edited
Loading

This PR reorganizes previews so they can be made for PRs from outside contributors.
The idea is to build a Docker image on the pull_request trigger (doesn't require write access to target repo / read access to our secrets), and later deploy it directly to fly.io.

@SleepyLeslie SleepyLeslie added the preview Launch preview deployment of this PR label Jun 26, 2024
@SleepyLeslie SleepyLeslie marked this pull request as draft June 26, 2024 22:11
@SleepyLeslie SleepyLeslie force-pushed the main branch 2 times, most recently from 21667f5 to 028e633 Compare June 28, 2024 04:33
@SleepyLeslie SleepyLeslie changed the title Dummy PR Enable external contributors to use previews Jun 28, 2024
@SleepyLeslie SleepyLeslie changed the title Enable external contributors to use previews Enable external contributors to create previews Jun 28, 2024
@SleepyLeslie SleepyLeslie marked this pull request as ready for review June 28, 2024 21:04
@SleepyLeslie
Copy link
Collaborator Author

To test this PR:

  • Make your own fork of grist-core.
  • In your fork, create a secret named FLY_API_TOKEN. Paste your fly.io API token there.
  • Fork your grist-core fork and create a PR from there to your grist-core fork.
  • Attach the preview label to your PR.

@SleepyLeslie SleepyLeslie removed the preview Launch preview deployment of this PR label Jun 28, 2024
@SleepyLeslie SleepyLeslie requested review from dsagal and paulfitz June 28, 2024 21:33
dsagal
dsagal reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just have a few requests for more comments. Thank you!

buildtools/fly-deploy.js Outdated Show resolved Hide resolved
.github/workflows/fly-destroy.yml Outdated Show resolved Hide resolved
.github/workflows/fly-destroy.yml Show resolved Hide resolved
.github/workflows/fly-deploy.yml Show resolved Hide resolved
dsagal
dsagal approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Leslie! Looks good. (The remaining question about await vs then is purely stylistic, so OK to keep as is, leaving that up to you.)

@SleepyLeslie SleepyLeslie merged commit 2750ed6 into gristlabs:main Jul 3, 2024
11 checks passed
SleepyLeslie added a commit that referenced this pull request Jul 8, 2024
@SleepyLeslie
Enable external contributors to create previews (#1068)
5865134 
Reorganize preview workflows so that previews can be made for PRs from outside contributors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsagal dsagal dsagal approved these changes

@paulfitz paulfitz Awaiting requested review from paulfitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SleepyLeslie @dsagal