Skip to content

Commit

Permalink
fix: env vars must be integers
Browse files Browse the repository at this point in the history
  • Loading branch information
vviers committed Oct 14, 2024
1 parent 4f72f1f commit f0cae5f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/server/lib/ActionHistoryImpl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import {ISQLiteDB, ResultRow} from './SQLiteDB';
// on rows and the maximum total number of bytes in the "body" column.
// Pruning is done when the history has grown above these limits, to
// the specified factor.
const ACTION_HISTORY_MAX_ROWS = process.env.ACTION_HISTORY_MAX_ROWS || 1000;
const ACTION_HISTORY_MAX_BYTES = process.env.ACTION_HISTORY_MAX_BYTES || 1000 * 1000 * 1000; // 1 GB.
const ACTION_HISTORY_MAX_ROWS = parseInt(process.env.ACTION_HISTORY_MAX_ROWS, 10) || 1000;

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :server-2-of-2:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[O-R]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[E-L]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[^A-R]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[M-N]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :server-1-of-2:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[A-D]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (:lint:python:client:common:smoke:, 22.x, 3.10)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 20 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :lint:python:client:common:smoke:stubs:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
const ACTION_HISTORY_MAX_BYTES = parseInt(process.env.ACTION_HISTORY_MAX_BYTES, 10) || 1000 * 1000 * 1000; // 1 GB.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :server-2-of-2:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[O-R]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[E-L]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[^A-R]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[M-N]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :server-1-of-2:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :nbrowser-^[A-D]:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (:lint:python:client:common:smoke:, 22.x, 3.10)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

Check failure on line 21 in app/server/lib/ActionHistoryImpl.ts

View workflow job for this annotation

GitHub Actions / build_and_test (3.11, 22.x, :lint:python:client:common:smoke:stubs:)

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
const ACTION_HISTORY_GRACE_FACTOR = 1.25; // allow growth to 1.25 times the above limits.
const ACTION_HISTORY_CHECK_PERIOD = 10; // number of actions between size checks.

Expand Down

0 comments on commit f0cae5f

Please sign in to comment.