Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Al-Jazeera source #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jasuarez
Copy link
Member

Provides a live stream channel to watch Al-Jazeera TV.

Provides a live stream channel to watch Al-Jazeera TV.
@hadess
Copy link
Contributor

hadess commented Jan 4, 2016

Couple of comments:

  • Seems weird that you'd only have a single URL/media to pass to the calling application, aren't there more separate streams in different languages, or with different subtitles?
  • the URL looks complicated, and most likely generated. Why not grab the web page/JSON file or wherever that contains it to generate it?
  • this is a normal TV channel, why put it in grilo-lua-sources, which is usually for NSFW content, or slightly sketchy websites? I'd put it in grilo-plugins directly.

@jasuarez
Copy link
Member Author

jasuarez commented Jan 7, 2016

  • Besides the live streaming, which is the one I'm focused on, and there's only one live stream, there are other stored videos that could be exposed. My aim is to just expose the live stream now, and try to add the others in the future
  • I got the URL from the Kodi plugin. Seems we can't extract that URL from the page itself. If in future we add more videos, those will be obtained from the page itself.
  • Yeah, I had doubts if pushing it directly to grilo-lua-sources. As you seem to prefer grilo-lua-sources then I'll close this PR and create a bug with the source.

@hadess
Copy link
Contributor

hadess commented Jan 7, 2016

Besides the live streaming, which is the one I'm focused on, and there's only one live stream, there are other stored videos that could be exposed. My aim is to just expose the live stream now, and try to add the others in the future

OK.

I got the URL from the Kodi plugin. Seems we can't extract that URL from the page itself. If in future we add more videos, those will be obtained from the page itself.

Can you add a link to the source file that declares it in gitweb/github?

Yeah, I had doubts if pushing it directly to grilo-lua-sources. As you seem to prefer grilo-lua-sources then I'll close this PR and create a bug with the source.

Yes, seems fitting given the euronews plugin we also have.

@jasuarez
Copy link
Member Author

jasuarez commented Jan 7, 2016

URL got from https://github.com/xbmc/repo-plugins/blob/gotham/plugin.video.aljazeera/addon.py#L125

Do you mean adding this URL as a comment in the Lua plugin?

@hadess
Copy link
Contributor

hadess commented Jan 7, 2016

Do you mean adding this URL as a comment in the Lua plugin?

Yes, so that it can be updated easily when or if it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants