Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity subject fixes #1150

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Activity subject fixes #1150

merged 2 commits into from
Oct 31, 2024

Conversation

acoffman
Copy link
Member

When Variant Coordinates were accepted, the subject was set as the underlying coordinate models, allowing that fact to leak through to the users.

Now, instead of setting the activity subject to the revision's subject, it will be set to the revision's creation activity's subject (which will be the variant).

Removes VariantCoordinate and ExonCoordinate as valid subject types.

We will need to run the following backfill script on deploy:

a = Activity.where(subject_type: ['ExonCoordinate', 'VariantCoordinate']).all
a.each { |x| x.subject = x.linked_revisions.first.creation_activity.subject; x.save! }

@acoffman acoffman added the bugfix PR Label for bug fixes. Will appear in release notes. label Oct 30, 2024
@acoffman acoffman merged commit 838e3ef into main Oct 31, 2024
5 checks passed
@acoffman acoffman deleted the activity-subject-fixes branch October 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR Label for bug fixes. Will appear in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant