rank typeahead results by length of matched name

griffithlab · Jan 28, 2025 · 4ed58e9 · 4ed58e9
1 parent f7beda9
commit 4ed58e9
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/server/app/graphql/types/queries/typeahead_queries.rb b/server/app/graphql/types/queries/typeahead_queries.rb
@@ -81,13 +81,13 @@ def disease_typeahead(query_term:)
         base_query = Disease.where(deprecated: false)
         results = base_query.where("diseases.name ILIKE ?", "%#{query_term}%")
           .or(base_query.where("diseases.doid ILIKE ?", "#{query_term}%"))
-          #.order("LENGTH(diseases.name) ASC")
+          .order("LENGTH(diseases.name) ASC")
           .limit(10)
         if results.size < 10
           secondary_results = base_query.eager_load(:disease_aliases)
             .where("disease_aliases.name ILIKE ?", "%#{query_term}%")
             .where.not(id: results.select('id'))
-            #.order("LENGTH(diseases.name) ASC")
+            .order("LENGTH(diseases.name) ASC")
             .distinct
             .limit(10-results.size)
           return results + secondary_results
@@ -100,7 +100,7 @@ def therapy_typeahead(query_term:)
         base_query = Therapy.where(deprecated: false)
         results = base_query.where("therapies.name ILIKE ?", "#{query_term}%")
           .or(base_query.where("therapies.ncit_id ILIKE ?", "%#{query_term}%"))
-          #.order("LENGTH(therapies.name) ASC")
+          .order("LENGTH(therapies.name) ASC")
           .limit(10)
         if results.size < 10
           secondary_results = base_query.where('therapies.name ILIKE ?', "%#{query_term}%")
@@ -110,7 +110,7 @@ def therapy_typeahead(query_term:)
             tertiary_results = base_query.eager_load(:therapy_aliases)
               .where("therapy_aliases.name ILIKE ?", "%#{query_term}%")
               .where.not(id: results.select('id') + secondary_results.select('id'))
-              #.order("LENGTH(therapies.name) ASC")
+              .order("LENGTH(therapies.name) ASC")
               .distinct
               .limit(10-results.size)
 
@@ -131,14 +131,14 @@ def feature_typeahead(query_term:, feature_type: nil)
                      end
 
         results = base_query.where('features.name ILIKE ?', "#{query_term}%")
-          #.order("LENGTH(features.name) ASC")
+          .order("LENGTH(features.name) ASC")
           .limit(10)
 
         if results.size < 10
           secondary_results = base_query.eager_load(:feature_aliases)
             .where("feature_aliases.name ILIKE ?", "#{query_term}%")
             .where.not(id: results.select('id'))
-            #.order("LENGTH(features.name) ASC")
+            .order("LENGTH(features.name) ASC")
             .distinct
             .limit(10 - results.size)
           return (results + secondary_results).uniq