FIX: return status bug, add tests

.dockerignore

@@ -1,2 +1,3 @@
 node_modules
-target
+target
+bin

.gitignore

@@ -1,5 +1,6 @@
 bin
 test/actual
+test/output
 
 /target
 /test_input

Dockerfile

@@ -1,4 +1,4 @@
-FROM clux/muslrust as build
+FROM clux/muslrust:nightly-2020-10-17 as build
 
 WORKDIR /build
 COPY Cargo.toml Cargo.lock /build/
@@ -29,7 +29,7 @@ RUN mkdir /fcheck/config &&\
     mkdir /fcheck/data &&\
     mkdir /fcheck/output
 
-COPY --from=build /build/target/x86_64-unknown-linux-musl/release/fcheck /app
+COPY --from=build /build/target/x86_64-unknown-linux-musl/release/fcheck /bin
 
 CMD ["./fcheck"]
 
@@ -51,6 +51,6 @@ RUN mkdir /fcheck/config &&\
     mkdir /fcheck/data &&\
     mkdir /fcheck/output
 
-COPY --from=build /build/target/x86_64-unknown-linux-musl/release/fcheck /app
+COPY --from=build /build/target/x86_64-unknown-linux-musl/release/fcheck /bin
 
 CMD ["./fcheck"]

README.md

@@ -287,9 +287,16 @@ To run in docker:
 docker run -v ${PWD}/config/:/fcheck/config/ -v ${PWD}/data/:/fcheck/data/ fcheck -c ./examples/config.toml -r ./data/report.json
 ```
 
-### Rust
+### High Priority Tasks
 
-```bash
-cargo build
-cargo run -- -c ./config/config-v3.toml
-```
+* Bug: fcheck returning exit code 0, event though tests have failed
+
+### Other Tasks
+
+* Add support for other shells: bash, zsh. This will allow support in Alpine.
+* Handle all warnings, code cleanup
+* Add version to binary based on VERSION file
+* Make output report readable
+* Add examples
+* Compile to different docker container bases
+* Add Dhall support

build.sh

@@ -9,11 +9,11 @@ echo "Start Build"
 docker build --target alpine -t $TAG . || exit $?
 echo "End Build"
 
-source_path=/app
-destination_path=./bin/$VERSION/fcheck
+source_path=/bin/fcheck
+destination_dir=./bin/$VERSION
 
-mkdir -p $destination_path
+mkdir -p $destination_dir
 
 container_id=$(docker create $TAG)
-docker cp $container_id:$source_path $destination_path
+docker cp $container_id:$source_path $destination_dir
 docker rm $container_id

examples/simple-http/Dockerfile

@@ -0,0 +1,22 @@
+FROM debian:stretch as debian-stretch
+
+WORKDIR /fcheck
+
+RUN wget https://github.com/gregberns/fcheck/releases/download/0.3.0/fcheck
+
+# Install any needed libraries
+# * `wdiff` has been quite useful for checking text files
+# * `netcat` ensures a service's port is open before fcheck starts tests
+RUN apt-get update &&\
+    apt-get install -y --no-install-recommends wdiff netcat &&\
+    apt-get clean && rm -rf /var/lib/apt/lists/*
+
+# Config is for the `fcheck-config.toml` file
+RUN mkdir /fcheck/config &&\
+    # The data directory is used for `actual` and `expected` folders to diff test results
+    mkdir /fcheck/data &&\
+    # The output directory can be used for the output report
+    mkdir /fcheck/output
+
+# For local testing, its helpful to just mount the `fcheck-config.toml`, then the container isn't rebuilt every time
+CMD ["/bin/fcheck", "--config-file", "/fcheck/config/fcheck-config.toml", "--report-file", "/output/report.json"]