Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Commit

Permalink
Point go-sqlmock dependency to github repo
Browse files Browse the repository at this point in the history
WARNING: This is a breaking change. If your project uses this library as
a dependency there is a good chance this change will affect your
project.  There are functions in testhelper whose inputs are
go-sqlmock.v1 objects.  This would result in your project trying to pass
a go-sqlmock.v1 object into a function that requires a go-sqlmock object

This is a workaround for an issue the gopkg.in repo is causing with go
modules.

Authored-by: Kevin Yeap <[email protected]>
  • Loading branch information
kyeap-vmware committed Sep 23, 2019
1 parent c535ba3 commit f202136
Show file tree
Hide file tree
Showing 4 changed files with 52 additions and 17 deletions.
63 changes: 49 additions & 14 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cluster/cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"os/user"
"testing"

sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
sqlmock "github.com/DATA-DOG/go-sqlmock"

"github.com/greenplum-db/gp-common-go-libs/cluster"
"github.com/greenplum-db/gp-common-go-libs/dbconn"
Expand Down
2 changes: 1 addition & 1 deletion dbconn/dbconn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/greenplum-db/gp-common-go-libs/dbconn"
"github.com/greenplum-db/gp-common-go-libs/operating"
"github.com/greenplum-db/gp-common-go-libs/testhelper"
sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
sqlmock "github.com/DATA-DOG/go-sqlmock"

"github.com/jmoiron/sqlx"
. "github.com/onsi/ginkgo"
Expand Down
2 changes: 1 addition & 1 deletion testhelper/functions.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/gbytes"
sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
sqlmock "github.com/DATA-DOG/go-sqlmock"
)

/*
Expand Down

0 comments on commit f202136

Please sign in to comment.