Fix: openvasd: get result detail source from right place

[mattmundell]

What

In openvasd_parsed_results, get detail_source_* from detail > source > *, instead of from detail > value > *.

Why

This seems to be the intention, according to the API and rust code.

Note that this also catches a problem where cJSON_GetObjectItem (detail_obj, "type") could have been called when detail_obj was NULL.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2b06d20.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

[github-actions]

🔍 Vulnerabilities of harbor-os.greenbone.net/community/gvm-libs:853-merge-amd64

📦 Image Reference harbor-os.greenbone.net/community/gvm-libs:853-merge-amd64

digest	sha256:77dd9730ed727ee4e084bf8c6ca7b6017abe3b5c498729aa5115861c290b7ada
vulnerabilities
size	79 MB
packages	198

📦 Base Image debian:testing-20241223-slim

also known as	testing-slim
digest	sha256:4a8e51c14260356eb52778260ef0a4080bbf6cb4698adeeba3fbdf85f7947a85
vulnerabilities

libxml2 2.12.7+dfsg+really2.9.14-0.2+b1 (deb) pkg:deb/debian/[email protected]%2Bdfsg%2Breally2.9.14-0.2%2Bb1?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=2.12.7+dfsg+really2.9.14-0.2 Fixed version Not Fixed EPSS Score 0.05% EPSS Percentile 23rd percentile Description An issue was discovered in libxml2 before 2.11.7 and 2.12.x before 2.12.5. When using the XML Reader interface with DTD validation and XInclude expansion enabled, processing crafted XML documents can lead to an xmlValidatePopElement use-after-free. Affected range >=2.12.7+dfsg+really2.9.14-0.2 Fixed version Not Fixed EPSS Score 0.08% EPSS Percentile 36th percentile Description libxml2 through 2.11.5 has a use-after-free that can only occur after a certain memory allocation fails. This occurs in xmlUnlinkNode in tree.c. NOTE: the vendor's position is "I don't think these issues are critical enough to warrant a CVE ID ... because an attacker typically can't control when memory allocations fail." Affected range >=2.12.7+dfsg+really2.9.14-0.2 Fixed version Not Fixed EPSS Score 0.06% EPSS Percentile 29th percentile Description Xmlsoft Libxml2 v2.11.0 was discovered to contain an out-of-bounds read via the xmlSAX2StartElement() function at /libxml2/SAX2.c. This vulnerability allows attackers to cause a Denial of Service (DoS) via supplying a crafted XML file. NOTE: the vendor's position is that the product does not support the legacy SAX1 interface with custom callbacks; there is a crash even without crafted input. Affected range >=2.12.7+dfsg+really2.9.14-0.2 Fixed version Not Fixed EPSS Score 0.04% EPSS Percentile 12th percentile Description An issue was discovered in xmllint (from libxml2) before 2.11.8 and 2.12.x before 2.12.7. Formatting error messages with xmllint --htmlout can result in a buffer over-read in xmlHTMLPrintFileContext in xmllint.c.

pam 1.5.3-7 (deb) pkg:deb/debian/[email protected]?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=1.5.3-7 Fixed version Not Fixed EPSS Score 0.05% EPSS Percentile 24th percentile Description A vulnerability was found in PAM. The secret information is stored in memory, where the attacker can trigger the victim program to execute by sending characters to its standard input (stdin). As this occurs, the attacker can train the branch predictor to execute an ROP chain speculatively. This flaw could result in leaked passwords, such as those found in /etc/shadow while performing authentications. Affected range >=1.5.3-7 Fixed version Not Fixed EPSS Score 0.09% EPSS Percentile 40th percentile Description A flaw was found in pam_access, where certain rules in its configuration file are mistakenly treated as hostnames. This vulnerability allows attackers to trick the system by pretending to be a trusted hostname, gaining unauthorized access. This issue poses a risk for systems that rely on this feature to control who can access certain services or terminals.

krb5 1.21.3-3 (deb) pkg:deb/debian/[email protected]?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=1.21.3-3 Fixed version Not Fixed EPSS Score 0.04% EPSS Percentile 11th percentile Description Kerberos 5 (aka krb5) 1.21.2 contains a memory leak vulnerability in /krb5/src/kdc/ndr.c. Affected range >=1.21.3-3 Fixed version Not Fixed EPSS Score 0.04% EPSS Percentile 11th percentile Description Kerberos 5 (aka krb5) 1.21.2 contains a memory leak vulnerability in /krb5/src/lib/gssapi/krb5/k5sealv3.c. Affected range >=1.21.3-3 Fixed version Not Fixed EPSS Score 0.04% EPSS Percentile 11th percentile Description Kerberos 5 (aka krb5) 1.21.2 contains a memory leak in /krb5/src/lib/rpc/pmap_rmt.c. Affected range >=1.21.3-3 Fixed version Not Fixed EPSS Score 0.09% EPSS Percentile 39th percentile Description An issue was discovered in MIT Kerberos 5 (aka krb5) through 1.16. There is a variable "dbentry->n_key_data" in kadmin/dbutil/dump.c that can store 16-bit data but unknowingly the developer has assigned a "u4" variable to it, which is for 32-bit data. An attacker can use this vulnerability to affect other artifacts of the database as we know that a Kerberos database dump file contains trusted data.

openldap 2.5.19+dfsg-1 (deb) pkg:deb/debian/[email protected]%2Bdfsg-1?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=2.5.19+dfsg-1 Fixed version Not Fixed EPSS Score 0.16% EPSS Percentile 53rd percentile Description libldap in certain third-party OpenLDAP packages has a certificate-validation flaw when the third-party package is asserting RFC6125 support. It considers CN even when there is a non-matching subjectAltName (SAN). This is fixed in, for example, openldap-2.4.46-10.el8 in Red Hat Enterprise Linux. Affected range >=2.5.19+dfsg-1 Fixed version Not Fixed EPSS Score 0.49% EPSS Percentile 76th percentile Description contrib/slapd-modules/nops/nops.c in OpenLDAP through 2.4.45, when both the nops module and the memberof overlay are enabled, attempts to free a buffer that was allocated on the stack, which allows remote attackers to cause a denial of service (slapd crash) via a member MODDN operation. Affected range >=2.5.19+dfsg-1 Fixed version Not Fixed EPSS Score 0.05% EPSS Percentile 23rd percentile Description slapd in OpenLDAP 2.4.45 and earlier creates a PID file after dropping privileges to a non-root account, which might allow local users to kill arbitrary processes by leveraging access to this non-root account for PID file modification before a root script executes a "kill cat /pathname" command, as demonstrated by openldap-initscript. Affected range >=2.5.19+dfsg-1 Fixed version Not Fixed EPSS Score 0.30% EPSS Percentile 69th percentile Description The nss_parse_ciphers function in libraries/libldap/tls_m.c in OpenLDAP does not properly parse OpenSSL-style multi-keyword mode cipher strings, which might cause a weaker than intended cipher to be used and allow remote attackers to have unspecified impact via unknown vectors.

coreutils 9.5-1+b1 (deb) pkg:deb/debian/[email protected]%2Bb1?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=9.5-1 Fixed version Not Fixed EPSS Score 0.04% EPSS Percentile 5th percentile Description In GNU Coreutils through 8.29, chown-core.c in chown and chgrp does not prevent replacement of a plain file with a symlink during use of the POSIX "-R -L" options, which allows local users to modify the ownership of arbitrary files by leveraging a race condition. Affected range >=9.5-1 Fixed version Not Fixed EPSS Score 0.04% EPSS Percentile 5th percentile Description chroot in GNU coreutils, when used with --userspec, allows local users to escape to the parent session via a crafted TIOCSTI ioctl call, which pushes characters to the terminal's input buffer.

shadow 1:4.16.0-7 (deb) pkg:deb/debian/shadow@1:4.16.0-7?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=1:4.16.0-7 Fixed version Not Fixed EPSS Score 0.04% EPSS Percentile 18th percentile Description shadow-utils (aka shadow) 4.4 through 4.17.0 establishes a default /etc/subuid behavior (e.g., uid 100000 through 165535 for the first user account) that can realistically conflict with the uids of users defined on locally administered networks, potentially leading to account takeover, e.g., by leveraging newuidmap for access to an NFS home directory (or same-host resources in the case of remote logins by these local network users). NOTE: it may also be argued that system administrators should not have assigned uids, within local networks, that are within the range that can occur in /etc/subuid. Affected range >=1:4.16.0-7 Fixed version Not Fixed EPSS Score 0.17% EPSS Percentile 55th percentile Description initscripts in rPath Linux 1 sets insecure permissions for the /var/log/btmp file, which allows local users to obtain sensitive information regarding authentication attempts. NOTE: because sshd detects the insecure permissions and does not log certain events, this also prevents sshd from logging failed authentication attempts by remote attackers.

sqlite3 3.46.1-1 (deb) pkg:deb/debian/[email protected]?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=3.43.1-1 Fixed version Not Fixed Description sqlite3 v3.40.1 was discovered to contain a segmentation violation at /sqlite3_aflpp/shell.c. Affected range >=3.46.1-1 Fixed version Not Fixed EPSS Score 0.28% EPSS Percentile 68th percentile Description A Memory Leak vulnerability exists in SQLite Project SQLite3 3.35.1 and 3.37.0 via maliciously crafted SQL Queries (made via editing the Database File), it is possible to query a record, and leak subsequent bytes of memory that extend beyond the record, which could let a malicious user obtain sensitive information. NOTE: The developer disputes this as a vulnerability stating that If you give SQLite a corrupted database file and submit a query against the database, it might read parts of the database that you did not intend or expect.

glib2.0 2.82.4-1 (deb) pkg:deb/debian/[email protected]?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=2.82.4-1 Fixed version Not Fixed EPSS Score 0.16% EPSS Percentile 52nd percentile Description GLib 2.31.8 and earlier, when the g_str_hash function is used, computes hash values without restricting the ability to trigger hash collisions predictably, which allows context-dependent attackers to cause a denial of service (CPU consumption) via crafted input to an application that maintains a hash table. NOTE: this issue may be disputed by the vendor; the existence of the g_str_hash function is not a vulnerability in the library, because callers of g_hash_table_new and g_hash_table_new_full can specify an arbitrary hash function that is appropriate for the application.

perl 5.40.0-8 (deb) pkg:deb/debian/[email protected]?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=5.40.0-8 Fixed version Not Fixed EPSS Score 0.16% EPSS Percentile 53rd percentile Description _is_safe in the File::Temp module for Perl does not properly handle symlinks.

gnutls28 3.8.8-2 (deb) pkg:deb/debian/[email protected]?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=3.8.8-2 Fixed version Not Fixed EPSS Score 1.43% EPSS Percentile 86th percentile Description The SSL protocol, as used in certain configurations in Microsoft Windows and Microsoft Internet Explorer, Mozilla Firefox, Google Chrome, Opera, and other products, encrypts data by using CBC mode with chained initialization vectors, which allows man-in-the-middle attackers to obtain plaintext HTTP headers via a blockwise chosen-boundary attack (BCBA) on an HTTPS session, in conjunction with JavaScript code that uses (1) the HTML5 WebSocket API, (2) the Java URLConnection API, or (3) the Silverlight WebClient API, aka a "BEAST" attack.

openssl 3.3.2-2 (deb) pkg:deb/debian/[email protected]?os_distro=trixie&os_name=debian&os_version=unstable Affected range >=3.2.2-1 Fixed version Not Fixed EPSS Score 0.07% EPSS Percentile 31st percentile Description OpenSSL 0.9.8i on the Gaisler Research LEON3 SoC on the Xilinx Virtex-II Pro FPGA uses a Fixed Width Exponentiation (FWE) algorithm for certain signature calculations, and does not verify the signature before providing it to a caller, which makes it easier for physically proximate attackers to determine the private key via a modified supply voltage for the microprocessor, related to a "fault-based attack."

[mattmundell]

Hey @jjnicola, saw this while trying some cleanup in #852. This is what you had in mind, right? It compiles, but I still have to set up the JSON things. Maybe you can test?

[bjoernricks]

As @mattmundell wrote it would be nice to get tests for this code. Without tests this code is prone to errors like this one.

[mattmundell]

After some digging through the code, I now have the Rust scanner set up and I've confirmed that this fits with a JSON based scan. So it's good to go.

I've also added a test case for host details.