-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses psutils to get the cpu utilization #30
Conversation
uh, nice! Will merge that in when I do the rest of the auto functionality. The parameter will need to be renamed than. A funny note on a typo: "cpu_utalisation" Your autocorrect has created a german crippled variant of the english word that gave me quite a laugh |
A question on this: I suppose you have made this so you can easily use it on macOS. How does psutils internally get the CPU % on macOS? |
I did some research how psutils works.
https://web.mit.edu/darwin/src/modules/xnu/osfmk/man/host_statistics.html |
I also flagged this here: giampaolo/psutil#1700 |
We can also use this to decouple the XGBoostModel / SDIA metrics providers from our cpu-util metric providers, which would be quite nice. Especially for Mac, where we don't have a cpu-util provider |
@ArneTR can we merge this so I don't have to refer to a branch in my blog article? |
it still needs macOS code, or not? Currently this only really works under linux |
splendid! ❤️ |
While working on the cloud machine script it was quite annoying to have to keep the c script around. It looks like the c metrics provider and the psutils implementation give similar results. Also I can't see much difference on overhead on my development machine.
I think this will also make the ci scripts easier as we don't need to compile the metric provider all the time. I have the feeling I am missing something though. Why didn't we do this from the beginning?