Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial user documentation #124

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Add initial user documentation #124

merged 8 commits into from
Jul 15, 2024

Conversation

mossmann
Copy link
Member

@mossmann mossmann commented Jul 12, 2024 •
edited
Loading

@mossmann mossmann requested review from antoinevg and martinling July 12, 2024 04:34
@mossmann mossmann linked an issue Jul 12, 2024 that may be closed by this pull request
Write user documentation for https://packetry.readthedocs.io #123
Closed
antoinevg
antoinevg reviewed Jul 12, 2024
View reviewed changes
docs/source/conf.py Show resolved Hide resolved
docs/source/quick_start.rst Outdated Show resolved Hide resolved
docs/source/quick_start.rst Outdated Show resolved Hide resolved
docs/source/quick_start.rst Outdated Show resolved Hide resolved
martinling
martinling requested changes Jul 12, 2024
View reviewed changes
docs/source/quick_start.rst Show resolved Hide resolved
docs/source/quick_start.rst Outdated Show resolved Hide resolved
docs/source/user_interface.rst Outdated Show resolved Hide resolved
docs/source/user_interface.rst Outdated Show resolved Hide resolved
@mossmann mossmann requested review from antoinevg and martinling July 13, 2024 13:57
@martinling martinling mentioned this pull request Jul 13, 2024
Closed
martinling
martinling requested changes Jul 13, 2024
View reviewed changes
docs/source/quick_start.rst Outdated Show resolved Hide resolved
@mossmann mossmann requested a review from martinling July 13, 2024 21:52
martinling
martinling approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@martinling martinling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I suggested a couple of minor changes but they're not essential.

docs/source/quick_start.rst Outdated Show resolved Hide resolved
docs/source/quick_start.rst Show resolved Hide resolved
antoinevg
antoinevg approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@antoinevg antoinevg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinling martinling merged commit 2569d8b into greatscottgadgets:main Jul 15, 2024
8 checks passed
@mossmann mossmann deleted the docs branch July 16, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinling martinling martinling approved these changes

@antoinevg antoinevg antoinevg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write user documentation for https://packetry.readthedocs.io
3 participants
@mossmann @antoinevg @martinling