Skip to content

Commit

Permalink
Clean up comments
Browse files Browse the repository at this point in the history
  • Loading branch information
antoinevg committed Jul 26, 2024
1 parent 5712851 commit c42d77e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion appimage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ The appimage custom action lives inside the [`action.yml`](action.yml) file.

The [`linuxdeply-plugin-gtk`](https://github.com/linuxdeploy/linuxdeploy-plugin-gtk) plugin does a good job of making sure everything we need to run a gtk app is bundled but we can still reduce the image size significantly:

1. Remove any system libraries we don't actually link to.
1. Remove any system libraries we don't actually want to distribute as they could cause conflicts if users have different versions installed.
2. The plugin, for some reason, dereferences the library files when copying them over resulting in a massive size increase to the binary. Ordinarily one would just delete the dupes and run ldconfig but, for reasons (*'file is truncated'* - don't ask!), this doesn't work with the gtk libraries. So we do a simple little bash script instead to delete dupes and replace them with symlinks.
3. Finally, all libraries are stripped of all debug information.

Expand Down
5 changes: 3 additions & 2 deletions appimage/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ runs:
# cd to AppDir lib directory
cd $GITHUB_WORKSPACE/${{ inputs.appdir }}/usr/lib
# remove any system libraries we don't need
# remove any system libraries we don't want to include in case
# of conflicts with a user's system
rm -f libX*
rm -f libblkid*
rm -f libbsd*
Expand Down Expand Up @@ -65,7 +66,7 @@ runs:
# cd to AppDir /usr/share/doc directory
cd $GITHUB_WORKSPACE/${{ inputs.appdir }}/usr/share/doc
# remove any system licenses for libraries we don't actually link to
# remove any licenses for system libraries we don't distribute
rm -rf libblkid1
rm -rf libbsd0
rm -rf libxau6
Expand Down

0 comments on commit c42d77e

Please sign in to comment.