Clarify descriptions of SetInterface/GetInterface requests.

greatscottgadgets · Sep 18, 2024 · 227c040 · 227c040
1 parent 2087188
commit 227c040
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/usb.rs b/src/usb.rs
@@ -428,9 +428,8 @@ impl StandardRequest {
             },
             GetConfiguration => format!("Getting configuration"),
             SetConfiguration => format!("Setting configuration {}", fields.value),
-            GetInterface => format!("Getting interface {}", fields.index),
-            SetInterface => format!("Setting interface {} to {}",
-                                    fields.index, fields.value),
+            GetInterface => format!("Getting interface setting"),
+            SetInterface => format!("Setting alternate setting {}", fields.value),
             SynchFrame => format!("Synchronising frame"),
             Unknown => format!("Unknown standard request"),
         }

diff --git a/tests/iso-unambiguous/reference.txt b/tests/iso-unambiguous/reference.txt
@@ -744,7 +744,7 @@ Getting string descriptor #0 for device 27, reading 4 bytes
   OUT packet on 27.0, CRC 18
   DATA1 packet with CRC 0000 and no data
   ACK packet
-Setting interface 1 to 0 for interface 27.1
+Setting alternate setting 0 for interface 27.1
  SETUP transaction on 27.0 with 8 data bytes, ACK: [01, 0B, 00, 00, 01, 00, 00, 00]
   SETUP packet on 27.0, CRC 18
   DATA0 packet with CRC 04C5 and 8 data bytes: [01, 0B, 00, 00, 01, 00, 00, 00]
@@ -1132,7 +1132,7 @@ Class request #1, index 2, value 258 for interface 27.0, writing 1 bytes
   IN packet on 27.0, CRC 18
   DATA1 packet with CRC 0000 and no data
   ACK packet
-Setting interface 2 to 0 for interface 27.2
+Setting alternate setting 0 for interface 27.2
  SETUP transaction on 27.0 with 8 data bytes, ACK: [01, 0B, 00, 00, 02, 00, 00, 00]
   SETUP packet on 27.0, CRC 18
   DATA0 packet with CRC 40C5 and 8 data bytes: [01, 0B, 00, 00, 02, 00, 00, 00]
@@ -1586,7 +1586,7 @@ Class request #1, index 4, value 256 for interface 27.0, writing 4 bytes
   IN packet on 27.0, CRC 18
   DATA1 packet with CRC 0000 and no data
   ACK packet
-Setting interface 1 to 1 for interface 27.1
+Setting alternate setting 1 for interface 27.1
  SETUP transaction on 27.0 with 8 data bytes, ACK: [01, 0B, 01, 00, 01, 00, 00, 00]
   SETUP packet on 27.0, CRC 18
   DATA0 packet with CRC D5C4 and 8 data bytes: [01, 0B, 01, 00, 01, 00, 00, 00]
@@ -1598,7 +1598,7 @@ Setting interface 1 to 1 for interface 27.1
   IN packet on 27.0, CRC 18
   DATA1 packet with CRC 0000 and no data
   ACK packet
-Setting interface 2 to 1 for interface 27.2
+Setting alternate setting 1 for interface 27.2
  SETUP transaction on 27.0 with 8 data bytes, ACK: [01, 0B, 01, 00, 02, 00, 00, 00]
   SETUP packet on 27.0, CRC 18
   DATA0 packet with CRC 91C4 and 8 data bytes: [01, 0B, 01, 00, 02, 00, 00, 00]