Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Facedancer USB Timeout error #191

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

antoinevg
Copy link
Member

@antoinevg antoinevg commented Oct 2, 2024

This PR does a few things:

  • Update libgreat command abort handling to function as intended now that the most recent release fixed the bugs that were preventing it from functioning in a sane manner.
  • Resets the endpoint FIFO's before issuing a stall to ensure that we clear the USB peripheral state for future requests.
  • Primes the OUT endpoint to receive the host ZLP before writing a libgreat response.
  • Shortens the delay in the libgreat moondancer connect verb. This may result in the speed of the interface being reported incorrectly but this bug has been fixed in the upcoming luna-soc 0.3.x release.

closes #188

@antoinevg antoinevg requested a review from miek October 2, 2024 15:34
Copy link
Member

@miek miek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@antoinevg antoinevg merged commit d54a77f into greatscottgadgets:main Oct 8, 2024
18 checks passed
@antoinevg antoinevg deleted the antoinevg/fix-188 branch October 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback Error: USB Timeout
2 participants