Fixes for GetMaxRPM issues #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spindle plugin would always alarm on startup, as requesting incorrect register number for the max RPM value. Also hooking into driver reset, else value would never be retrieved if VFD was not responsive during startup.
|
Meant to say - something I noticed when testing. The very first soft reset after startup still has the sys.cold_start flag set..? |
|
Seems I clicked the wrong button, my comment was lost...
Good catch, I'll reset it in the main protocol loop after all the startup tests has been completed. |
terjeio
added a commit
that referenced
this pull request
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spindle plugin would always alarm on startup, as requesting incorrect
register number for the max RPM value.
Also hooking into driver reset, else value would never be retrieved if VFD
was not responsive during startup.
See discussion -- #2 (comment)