Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AM-4731 ext grant message #5438

Open
wants to merge 1 commit into
base: 4.3.x
Choose a base branch
from
Open

AM-4731 ext grant message #5438

wants to merge 1 commit into from

Conversation

lgw-gravitee
Copy link
Contributor

fixes AM-4731

@lgw-gravitee lgw-gravitee requested review from a team as code owners January 31, 2025 08:19
leleueri
leleueri requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@leleueri leleueri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the only place where InvalidGrantException is thrown without message. Looks like there is another InvalidGrantException in package io.gravitee.am.gateway.handler.oauth2.exception. Maybe the ExtensionGrant should use the exception coming from the handler 🤔

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leleueri leleueri leleueri requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
apply-on-4-4-x apply-on-4-5-x apply-on-4-6-x apply-on-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgw-gravitee @leleueri