chore: update bindings version #317
Conversation
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
from
48d9c3d to
7d59482
Compare
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
from
7d59482 to
0aec55b
Compare
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
6 times, most recently
from
d3db0b0 to
00db6ef
Compare
Yes |
any updates on filter v2? |
Do we need it? |
arguably needed when a user wants to participate as a light client with limited load requirements. if v2 exists the filter protocol should have similar api if not the same, so it is better to include as we have the flow already. if v2 doesn't exist then it is fine to remove so we can proceed without memory leak |
Ok I will spend some time looking at whether it's trivial to include it and keep the current filter functionality |
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
8 times, most recently
from
b98d5a9 to
a126223
Compare
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
from
a126223 to
aa4ae1e
Compare
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
from
aa4ae1e to
53eb639
Compare
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
3 times, most recently
from
29fafc5 to
7bf9f8c
Compare
| @@ -456,9 +458,6 @@ impl GraphcastAgent { | |||
| "Selected content topic from subscriptions" | |||
| ); | |||
|
|
|||
| // Check network before sending a message | |||
| self.network_check() | |||
There was a problem hiding this comment.
would you please briefly explain why this function is no longer called?
There was a problem hiding this comment.
this function is very slow now that we're using waku's discovery ENR, it takes about 250-300s each time and it blocks message sending, I opted into calling it every 5 minutes in the Radio itself
There was a problem hiding this comment.
depending on whether network connectivity should be handled by the sdk, we can later on refactor the function to make sure it doesn't take that long, but okay here
src/graphcast_agent/waku_handling.rs
Outdated
| @@ -192,6 +182,8 @@ fn node_config( | |||
| gossipsub_params: Some(gossipsub_params), | |||
| dns4_domain_name: None, | |||
| websocket_params: None, | |||
| dns_discovery_urls: vec![], | |||
There was a problem hiding this comment.
should these 2 params be passed in from the radio since we have those configs iirc?
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
from
7bf9f8c to
dfb06e6
Compare
pete-eiger
force-pushed
the
update-waku-bindings-version
branch
from
dfb06e6 to
4d50b93
Compare
Updated waku bindings version and fixed conflicts. This update should fix the memory leak issue in the bindings, it also includes updates for deprecating the legacy filter protocol and moving to filter v2.