Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos introduced by #1018 #1142

Draft
wants to merge 73 commits into
base: main
Choose a base branch
from
Draft

Fix typos introduced by #1018 #1142

wants to merge 73 commits into from

Conversation

quadratz
Copy link
Contributor

@quadratz quadratz commented Nov 3, 2024

#1018. Deployed preview: #1142 (comment)

KnorpelSenf and others added 30 commits March 21, 2024 18:09
- add examples on command scoping
- add examples on command grouping
- add regExp section
- add reference to telegram docs on commands
- add mention to languageCode obj utility
- typos
- remove wrong code on localization example
- add ignoreCase option
- update `did you mean` section to use the `commandNotFound` helper function
- remove backticks on command options for better in-document linking
@quadratz quadratz changed the title Sync @niusia-ua suggestions Fix typos introduced by #1018 Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

@github-actions github-actions bot temporarily deployed to pull request November 3, 2024 09:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 3, 2024 13:52 Inactive
@@ -36,6 +36,7 @@ Installing plugins is fun and easy, and we want you to know what we have in stor
| [Media Groups](./media-group) | _built-in_ | Simplify sending media groups and editing media |
| [Inline Queries](./inline-query) | _built-in_ | Easily build results for inline queries |
| [Auto-retry](./auto-retry) | [`auto-retry`](./auto-retry) | Automatically handle rate limiting |
| [Commands](./commands) | [`commands`](./commands) | Manage commands in a powerful way |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roziscoding @rojvv Please review this change as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely forgot that this overview exists

@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 08:04 Inactive
@quadratz quadratz marked this pull request as ready for review November 4, 2024 15:08
@quadratz
Copy link
Contributor Author

quadratz commented Nov 4, 2024

It might be better to keep this PQ as a draft until the comments in #1018 are resolved. I still have some suggestions left, but i'm waiting to see how the pending review goes.

@quadratz quadratz marked this pull request as draft November 4, 2024 15:17
@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 15:47 Inactive
@KnorpelSenf
Copy link
Member

KnorpelSenf commented Nov 13, 2024

Can you re-apply a72534d, 2bfe2c8 and e13a321 here?

Base automatically changed from commands-plugin to main November 17, 2024 10:27
@KnorpelSenf
Copy link
Member

@quadratz is this still a thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants