Connection pools #189
Open
Connection pools #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/extract debug
Separate files for UpstreamManager.
…ulti-threading request/response.
AlexanderSuprunenko
requested review from
mbg033,
LenyKholodov,
EDDragonWolf,
cybay and
bitkis
Some UpstreamManager bugs fixed.
AlexanderSuprunenko
force-pushed
the
feature/connection-bunches
branch
from
0275013 to
7c9ad69
Compare
A host resolution test added. Host resolution errors are handled.
mbg033
requested changes
Jan 25, 2019
data/config.ini
Outdated
| @@ -44,13 +45,17 @@ requests-per-sec=100 ;; maximal amount of requests per second in the window, 0 t | |||
| ban-ip-sec=300 ;; time duration in seconds to ban particular IP, 0 to ban forever | |||
|
|
|||
| [upstream] | |||
| default=127.0.0.1:28681 | |||
| blah=https://127.0.0.1:8080 | |||
| walletnode=http://127.0.0.1:28694 | |||
There was a problem hiding this comment.
format is very confusing and not self-explanatory, especially "keepAlive" - why just don't have it as last optional parameter? e.g.:
address[, timeout[, max_connections, [keep_alive]]]
There was a problem hiding this comment.
ok, suggesting following format:
<name>=<uri>[,<timeout-in-seconds>[,<max-active-connections-per-upstream>],max-active-connections-per-address,]]keep-alive]]]
because connections limit and keep alive are unrelated entities and right now keepAlive flag implicitly switches limit's scope (upstream limit vs address (aka unique host:port record))
There was a problem hiding this comment.
Comma-separated values with variable number of arguments are horrible and non-descriptive. How about:
<name>=<uri>
<name>-timeout=seconds
<name>-max-conns-upstream=count
<name>-max-conns-address=count
<name>-keep-alive=seconds
Open
bitkis
force-pushed
the
development/v.0.0.2
branch
from
27d5339 to
fc7a723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It includes #186