Rename name and nameChanged

common/network_manager.go

@@ -289,9 +289,9 @@ func (m *NetworkManager) emitResponseMetrics(resp *Response, req *Request) {
 // against user supplied regex. If there's a match a user supplied name will
 // be used instead of the url for the url tag, otherwise the url will be used.
 func handleURLTag(ctx context.Context, mi metricInterceptor, url string, tags *k6metrics.TagSet) *k6metrics.TagSet {
-	if name, ok := mi.urlTagName(ctx, url); ok {
-		tags = tags.With("url", name)
-		tags = tags.With("name", name)
+	if newTagName, urlMatched := mi.urlTagName(ctx, url); urlMatched {
+		tags = tags.With("url", newTagName)
+		tags = tags.With("name", newTagName)
 		return tags
 	}
 

common/page.go

@@ -381,8 +381,8 @@ func (p *Page) urlTagName(ctx context.Context, urlTag string) (string, bool) {
 		return "", false
 	}
 
-	var name string
-	var nameChanged bool
+	var newTagName string
+	var urlMatched bool
 	em := &MetricEvent{
 		urlTag: urlTag,
 	}
@@ -401,13 +401,13 @@ func (p *Page) urlTagName(ctx context.Context, urlTag string) (string, bool) {
 
 	// If a match was found then the name field in em will have been updated.
 	if em.name != nil {
-		name = *em.name
-		nameChanged = true
+		newTagName = *em.name
+		urlMatched = true
 	}
 
-	p.logger.Debugf("urlTagName", "name: %q nameChanged: %v", name, nameChanged)
+	p.logger.Debugf("urlTagName", "name: %q nameChanged: %v", newTagName, urlMatched)
 
-	return name, nameChanged
+	return newTagName, urlMatched
 }
 
 // MetricEvent is the type that is exported to JS. It is currently only used to