-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include entry metadata bytes in metrics tracking ingestion stats #9808
Include entry metadata bytes in metrics tracking ingestion stats #9808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome )
4176298
to
a83baaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please also check if we have the tests and add the test-case that covers the new logic .
also, could you please update debug log that we have at the bottom of the method to print the size of non-indexed metadata separately.... it might be super useful during the investigation
@vlad-diachenko Done
As far as I can see, we are not testing the |
In general we use |
You can also use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, left just a minor nit. Let us add some tests as suggested by Vlad.
Co-authored-by: Sandeep Sukhani <[email protected]>
Thank you @sandeepsukhani , I've added a test for the metrics :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
In #9694 we added support for adding metadata labels to each entry in a push payload. In this PR we update the following metrics to take into account the bytes needed to store those labels:
loki_distributor_bytes_received_total
distributor_bytes_received
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/upgrading/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PR