Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: fix anchor link in the error message #4612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tanurrra
Copy link

@tanurrra tanurrra commented Mar 9, 2025

What?

Update anchor link to the official docs in the error message The moduleSpecifier "%s" couldn't be found on local disk. New anchor link is https://grafana.com/docs/k6/latest/using-k6/modules/#local-modules-2.

Why?

Anchor link https://grafana.com/docs/k6/latest/using-k6/modules/#using-local-modules-with-docker in the error message The moduleSpecifier "%s" couldn't be found on local disk... is not up-to date, so anchor link is being resolved to the beginning of the page.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the k6-documentation: grafana/k6-docs#PR-NUMBER
  • I have updated the TypeScript definitions: grafana/k6-DefinitelyTyped#PR-NUMBER
  • I have updated the release notes: link

Related PR(s)/Issue(s)

@tanurrra tanurrra requested a review from a team as a code owner March 9, 2025 19:59
@tanurrra tanurrra requested review from oleiade and codebien and removed request for a team March 9, 2025 19:59
@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025

CLA assistant check
All committers have signed the CLA.

@tanurrra tanurrra changed the title fix anchor link in the error message UX: fix anchor link in the error message Mar 9, 2025
@oleiade
Copy link
Member

oleiade commented Mar 10, 2025

Hey @tanurrra 👋🏻

For this fix, much appreciated 🙇🏻

@oleiade
Copy link
Member

oleiade commented Mar 10, 2025

@tanurrra CI reports that in order for us to be able to merge this, you should sign our CLA agreement. If you're fine with it, you can proceed by clicking on the license/cla check 👇🏻 and it will take you through the process 🙇🏻

CleanShot 2025-03-10 at 10 47 41

Signed-off-by: Tatyana Velikanova <[email protected]>
@tanurrra
Copy link
Author

@oleiade done. It was a problem because my commit had two authors (me and my other account) and CLA assistant didn't offer to sign for second author. I removed the second author and it fixed it.

@tanurrra CI reports that in order for us to be able to merge this, you should sign our CLA agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants