Chore: Close FDs on TestFileConsole to avoid issues on Win #4607
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
force-pushed
the
bumpGolangci-2
branch
from
a6042cf to
d5818b1
Compare
joanlopez
changed the title
joanlopez
commented
Mar 6, 2025
| @@ -378,7 +378,6 @@ func TestFileConsole(t *testing.T) { | |||
| f, err := os.CreateTemp(t.TempDir(), "") //nolint:forbidigo // fix with https://github.com/grafana/k6/issues/2565 | |||
| require.NoError(t, err) | |||
| logFilename := f.Name() | |||
| defer os.Remove(logFilename) //nolint:errcheck,forbidigo // fix with https://github.com/grafana/k6/issues/2565 | |||
There was a problem hiding this comment.
I think this line is no longer required, as t.TempDir() is responsible, thanks to t.Cleanup() behavior, to completely remove the temporary directory created for this test, once it finishes. Right?
There was a problem hiding this comment.
Seems reasonable - I did remove some lines like this from some places, but likely missed some as well
joanlopez
requested review from
mstoykov and
inancgumus
and removed request for
a team
mstoykov
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It closes the open file descriptors on the logger's output file on
TestFileConsole.Why?
Because, as discussed here, that's what's causing that test to fail on Windows.