Fix to remove browser downloads path #4288
Merged
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
requested review from
mstoykov and
oleiade
and removed request for
a team
ankur22
approved these changes
Jan 28, 2025
mstoykov
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM and thank you 🙇
This does get my *browser* directories in /tmp from 866 to 33.
The remaining ones are
- xk6-browser-data*
- k6browser-artifacts*
Which seem to be completely different parts, although we likely should at least remove the xk6- part 😅
But we can do in a separate PR.
Each BrowserContext has a downloads path. We now clean them up when the Browser they are associated with closes.
inancgumus
force-pushed
the
fix/browser-downloadspath-removal
branch
from
3305ce4 to
1fa34e6
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Each
BrowserContexthas a download path. We now clean them up when theBrowserthey are associated with closes.Why?
To avoid inflating the user's temporary directory folder.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)