Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbom github action to use node 20 #3628

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Mar 11, 2024

What?

Update sbom github action to use node20

Why?

Makes all our github actions use node 20

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.50.0 milestone Mar 11, 2024
@mstoykov mstoykov requested a review from a team as a code owner March 11, 2024 09:12
@mstoykov mstoykov requested review from oleiade and olegbespalov and removed request for a team March 11, 2024 09:12
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (47c5bb0) to head (0a04888).

❗ Current head 0a04888 differs from pull request most recent head 2c18fa1. Consider uploading reports for the commit 2c18fa1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3628   +/-   ##
=======================================
  Coverage   73.57%   73.58%           
=======================================
  Files         277      277           
  Lines       20244    20244           
=======================================
+ Hits        14895    14896    +1     
+ Misses       4401     4400    -1     
  Partials      948      948           
Flag Coverage Δ
macos 73.48% <ø> (ø)
ubuntu 73.50% <ø> (-0.02%) ⬇️
windows 73.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

olegbespalov
olegbespalov previously approved these changes Mar 11, 2024
oleiade
oleiade previously approved these changes Mar 11, 2024
@mstoykov mstoykov dismissed stale reviews from oleiade and olegbespalov via 2c18fa1 March 11, 2024 12:55
@mstoykov mstoykov merged commit 2e3920c into master Mar 11, 2024
23 of 24 checks passed
@mstoykov mstoykov deleted the updateSBOMToNode20 branch March 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants