Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some comments #3626

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix some comments #3626

merged 1 commit into from
Mar 11, 2024

Conversation

suchsoon
Copy link
Contributor

@suchsoon suchsoon commented Mar 9, 2024 •
edited
Loading

What?

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@suchsoon
fix some comments
1ef5377 
Signed-off-by: suchsoon <[email protected]>
@suchsoon suchsoon requested a review from a team as a code owner March 9, 2024 11:05
@suchsoon suchsoon requested review from mstoykov and oleiade and removed request for a team March 9, 2024 11:05
@CLAassistant
Copy link

CLAassistant commented Mar 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mstoykov
mstoykov approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @suchsoon 🙇

@mstoykov mstoykov added this to the v0.50.0 milestone Mar 11, 2024
@mstoykov mstoykov merged commit 5709aa7 into grafana:master Mar 11, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@oleiade oleiade oleiade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.50.0
Development

Successfully merging this pull request may close these issues.
4 participants
@suchsoon @CLAassistant @mstoykov @oleiade