Fix ramping-arrival-rate execution requirements #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
previously approved these changes
Feb 12, 2024
olegbespalov
previously approved these changes
Feb 12, 2024
|
Looks good 👍 Let's just fix the linter issue and merge it 💪 |
joanlopez
dismissed stale reviews from olegbespalov and mstoykov
via
504230d
Ha! Looks like I forgot to |
olegbespalov
approved these changes
Feb 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3593 +/- ##
==========================================
- Coverage 73.53% 73.47% -0.06%
==========================================
Files 277 275 -2
Lines 20201 20196 -5
==========================================
- Hits 14854 14839 -15
- Misses 4400 4404 +4
- Partials 947 953 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mstoykov
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It slightly modifies how the execution requirements are calculated to prevent issues when the execution is segmented and the
PreAllocatedVUsaren't evenly distributed (not divisible by the number of segments).Previously,
PreAllocatedVUswere not always correctly subtracted fromMaxVUs, causing weird situations during the load zone distribution calculations.Why?
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)