Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k6-browser Go module version to 1.20 #3590

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Bump k6-browser Go module version to 1.20 #3590

merged 1 commit into from
Feb 12, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Feb 12, 2024

What?

Bumps the Go module version to 1.20.

Why?

The browser team wants to use the new multi-error feature.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

N/A

@inancgumus inancgumus self-assigned this Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32c5f12) 73.07% compared to head (0d16c43) 73.54%.
Report is 2 commits behind head on master.

❗ Current head 0d16c43 differs from pull request most recent head 800fb1a. Consider uploading reports for the commit 800fb1a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3590      +/-   ##
==========================================
+ Coverage   73.07%   73.54%   +0.46%     
==========================================
  Files         281      277       -4     
  Lines       21102    20200     -902     
==========================================
- Hits        15421    14856     -565     
+ Misses       4705     4397     -308     
+ Partials      976      947      -29     
Flag Coverage Δ
macos 73.44% <100.00%> (+0.43%) ⬆️
ubuntu 73.46% <100.00%> (+0.45%) ⬆️
windows 73.38% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inancgumus inancgumus marked this pull request as ready for review February 12, 2024 11:00
@inancgumus inancgumus requested a review from a team as a code owner February 12, 2024 11:00
@inancgumus inancgumus requested review from mstoykov, olegbespalov and codebien and removed request for a team February 12, 2024 11:00
@codebien codebien merged commit 9dbf343 into master Feb 12, 2024
24 checks passed
@codebien codebien deleted the bump/go-1-20 branch February 12, 2024 15:52
@inancgumus inancgumus changed the title Bump Go module version to 1.20 Bump k6-browser Go module version to 1.20 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants