Document the csv parser's asObjects option
#1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
requested review from
inancgumus and
codebien
and removed request for
a team
oleiade
added
the
Area: OSS Content
codebien
requested changes
Feb 5, 2025
There was a problem hiding this comment.
On this page https://grafana.com/docs/k6/latest/javascript-api/k6-experimental/ the csv link redirects to the wrong page. Can you fix it, please? 🙏
docs/sources/k6/next/javascript-api/k6-experimental/csv/Options.md
Outdated
Show resolved
Hide resolved
|
Good catch @codebien I've fixed the link 🙇🏻 |
|
@oleiade Can you fix the broken links on the previous versions as well or at least on the latest online, please? |
inancgumus
approved these changes
Feb 5, 2025
docs/sources/k6/next/javascript-api/k6-experimental/csv/parse.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/javascript-api/k6-experimental/csv/Parser.md
Outdated
Show resolved
Hide resolved
docs/sources/k6/next/javascript-api/k6-experimental/csv/Options.md
Outdated
Show resolved
Hide resolved
Co-authored-by: İnanç Gümüş <[email protected]>
|
Fixed the broken links down to version 0.54 where the csv module was introduced. |
heitortsergent
approved these changes
Feb 5, 2025
docs/sources/k6/next/javascript-api/k6-experimental/csv/Options.md
Outdated
Show resolved
Hide resolved
| @@ -4,7 +4,7 @@ title: javascript-api/k6-experimental | |||
|
|
|||
| | Modules | Description | | |||
| | ------------------------------------------------------------------------------------------------ | -------------------------------------------------------------------------------------------------------------------------- | | |||
| | [csv](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/fs) | Provides support for efficient and convinient of parsing CSV files. | | |||
| | [csv](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/csv) | Provides support for efficient and convenient parsing of CSV files. | | |||
There was a problem hiding this comment.
Thanks for fixing this. 🙇
…s.md Co-authored-by: Heitor Tashiro Sergent <[email protected]>
codebien
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Documents the newly introduced
asObjectsoption of thek6/experimental/csvmodule.Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)
grafana/k6#4295