Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow that builds the website with both documentation sets #1840

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 14, 2025

What?

Requested by @heitortsergent to ensure that the docs are always buildable.

The same grafana/writers-toolkit/build-website composite Action gates publishing documentation in those publishing workflows to make sure that no docs break the website build after syncing.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

@jdbaldry jdbaldry mentioned this pull request Jan 14, 2025
4 tasks
@jdbaldry jdbaldry force-pushed the jdb/2025-01-add-website-test-workflow branch from 6450336 to 5dabd3a Compare January 14, 2025 12:32
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/ Thanks for adding this @jdbaldry! 🙇

@heitortsergent heitortsergent merged commit 78aeac2 into main Jan 14, 2025
4 checks passed
@heitortsergent heitortsergent deleted the jdb/2025-01-add-website-test-workflow branch January 14, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants