Replace httpbin references with QuickPizza #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicotdn
requested review from
oleiade and
codebien
and removed request for
a team,
oleiade and
codebien
federicotdn
commented
Jan 10, 2025
federicotdn
force-pushed
the
replace-httpbin
branch
2 times, most recently
from
ddd68c3 to
3e45498
Compare
federicotdn
commented
Jan 13, 2025
| const res = http.get(`http://example.com/posts`); | ||
| check(res, { | ||
| 'is status 200': (r) => r.status === 200, | ||
| export default function () { |
There was a problem hiding this comment.
Script was not working without the export function.
| @@ -14,10 +14,22 @@ | |||
| import tempfile | |||
| from collections import namedtuple | |||
|
|
|||
| Script = namedtuple("Script", ["text", "options"]) | |||
| Script = namedtuple("Script", ["text", "options", "env"]) | |||
|
|
|||
There was a problem hiding this comment.
Script has some new options, they are all documented though!
heitortsergent
approved these changes
Jan 14, 2025
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
federicotdn
force-pushed
the
replace-httpbin
branch
from
debe971 to
4bf22a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of https://github.com/grafana/k6-cloud/issues/2437.
Replace all uses of
httpbin.test.k6.iowith QuickPizza.TODO: Once this is reviewed, I'll apply the changes to older k6 versions.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)