Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace grpcbin.test.k6.io with QuickPizza #1817

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Replace grpcbin.test.k6.io with QuickPizza #1817

merged 5 commits into from
Dec 10, 2024

Conversation

federicotdn
Copy link
Contributor

@federicotdn federicotdn commented Nov 27, 2024

What?

Part of https://github.com/grafana/k6-cloud/issues/2437.
Replaces all uses of the old grpcbin.test.k6.io with the new gRPC endpoints in QuickPizza.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@federicotdn federicotdn marked this pull request as ready for review December 2, 2024 17:43
@federicotdn federicotdn requested review from heitortsergent and a team as code owners December 2, 2024 17:43
@federicotdn federicotdn requested review from mstoykov and oleiade and removed request for a team December 2, 2024 17:43
@olegbespalov
Copy link
Contributor

Do QuickPizza gRPC endpoints have any streaming capabilities, if yes, we could also benefit from updating our gRPC streaming examples (like https://grafana.com/docs/k6/next/javascript-api/k6-net-grpc/stream/stream-on/) which currently require running a local gRPC server?

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was able to run one of the updated examples pointing to grpc-quickpizza.grafana.com:443.

If you can please apply the changes to the latest and previous two versions, I think this should be good to merge. :shipit:

@federicotdn
Copy link
Contributor Author

@olegbespalov I need to do many changes to the docs so I'm trying to not add additional examples, however if we wanted to extend Quickpizza, then we only need to update https://github.com/grafana/quickpizza/blob/main/proto/quickpizza.proto and https://github.com/grafana/quickpizza/blob/main/pkg/grpc/grpc.go (should be super quick).

@federicotdn federicotdn merged commit ce4b291 into main Dec 10, 2024
3 checks passed
@federicotdn federicotdn deleted the qp-grpc branch December 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants