Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitForEvent in recommended docs page #1800

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Add waitForEvent in recommended docs page #1800

merged 5 commits into from
Nov 7, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Nov 6, 2024

What?

This adds a missing wait* (browserContext.waitForEvent) API in the recommended practices docs page.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

This adds a missing wait* API in the recommended practices docs page.
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides a few things 👍

ankur22 and others added 2 commits November 6, 2024 14:58
…mulate-user-input-delay.md

Co-authored-by: İnanç Gümüş <[email protected]>
…mulate-user-input-delay.md

Co-authored-by: İnanç Gümüş <[email protected]>
@ankur22
Copy link
Contributor Author

ankur22 commented Nov 6, 2024

@heitortsergent the validator job keeps failing, but i don't understand why. Can you assist?

This should help prevent a validator error in CI.
@ankur22 ankur22 merged commit 4c77b19 into main Nov 7, 2024
3 of 4 checks passed
@ankur22 ankur22 deleted the add/waitForEvent branch November 7, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants