Document new redis options #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
approved these changes
Nov 17, 2023
|
Summoning @heitortsergent and @jdbaldry regarding @codebien's question about plans to have a preview generated for PRs 👀 |
|
It's not currently prioritized for my quarter but I have https://github.com/grafana/technical-documentation/issues/847 to keep track of the want. I would like to see it for sure. In the mean time, a local preview is available by running |
48 tasks
heitortsergent
approved these changes
Nov 28, 2023
docs/sources/next/javascript-api/k6-experimental/redis/client/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/client/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/client/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/client/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/client/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/redis-options.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/redis-options.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/redis-options.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/redis-options.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/redis/redis-options.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
mstoykov
reviewed
Nov 29, 2023
| addrs: redis_addrs.split(',') || new Array('localhost:6379'), // in the form of 'host:port', separated by commas | ||
| password: redis_password, | ||
| }); | ||
| const redisClient = new redis.Client('redis://localhost:6379'); |
There was a problem hiding this comment.
This not only updates to the new API, but also removes using a password in the example.
Is this intentional? Do we still have examples with password?
There was a problem hiding this comment.
That's a fair point! We do illustrate using the password in the Client documentation, though 👍🏻
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k6 version 0.48 will introduce a breaking change in the way the
k6/experimental/redisClient class is constructed.This Pull Request documents the new API and its usage.
This is my first PR on the new version of the documentation, so 🤞🏻